feat: add support for create database #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvng
force-pushed
the
create-database
branch
from
0525ffb
to
c1f627b
Compare
|
not sure if we wait for #87 to have the snapshot in this PR |
cvng
force-pushed
the
create-database
branch
2 times, most recently
from
13d4b3f
to
c862fb1
Compare
psteinroe
requested changes
Dec 19, 2023
Comment on lines
20
to
24
| [email protected] "CONNECTION" | ||
| [email protected] " " | ||
| [email protected] "LIMIT" | ||
| [email protected] " " | ||
| [email protected] "5" |
There was a problem hiding this comment.
These should be part of DefElement
There was a problem hiding this comment.
thanks, fixed in 45f88be
Comment on lines
16
to
18
| [email protected] "LOCATION" | ||
| [email protected] " " | ||
| [email protected] "DEFAULT" |
There was a problem hiding this comment.
Should also be part of DefElement
cvng
force-pushed
the
create-database
branch
from
c862fb1
to
8b2fd25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
add support for
create databaseWhat is the current behavior?
panics
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.