Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade wrangler #12757

Closed
wants to merge 2 commits into from
Closed

fix: upgrade wrangler #12757

wants to merge 2 commits into from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Oct 6, 2024

Upgrading wrangler should resolve https://github.com/sveltejs/kit/security/dependabot/20 as it is the sole package relying on [email protected]. The latest version of wrangler uses [email protected] which no longer has this vulnerability.

Not sure about the changeset though. Is this a patch fix if wrangler is updated to a new minor?

EDIT: unfortunately this does not resolve https://github.com/sveltejs/kit/security/dependabot/24 where the latest wrangler still relies on [email protected] through [email protected]

wrangler dependency on cookie 0.5.0

cc: @dario-piotrowicz @jamesopstad


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: f809b0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino eltigerchino changed the title fix: upgrade wrangler chore: upgrade wrangler Oct 6, 2024
@eltigerchino eltigerchino changed the title chore: upgrade wrangler fix: upgrade wrangler Oct 6, 2024
@benmccann
Copy link
Member

This would be a breaking change requiring a new major since it would force people to upgrade the version of wrangler they're using. I wonder if we should consider something like #12452 instead

@eltigerchino
Copy link
Member Author

This would be a breaking change requiring a new major since it would force people to upgrade the version of wrangler they're using. I wonder if we should consider something like #12452 instead

Definitely in favour of the optional dependency 👍🏼. I’ll close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants