Heroku buildpack #40
Open
Heroku buildpack #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
reviewed
May 27, 2020
| * Proposal: SSWG-0012 | ||
| * Authors: [KyleF](https://github.com/kylef), [VZSG](https://github.com/vzsg) | ||
| * Sponsor(s): TBD | ||
| * Review Manager: [Logan Wright](https://github.com/loganwright) |
There was a problem hiding this comment.
Suggested change
| * Review Manager: [Logan Wright](https://github.com/loganwright) | |
| * Review Manager: [Tom Doron](https://github.com/tomerd) |
tomerd
reviewed
May 27, 2020
| * Authors: [KyleF](https://github.com/kylef), [VZSG](https://github.com/vzsg) | ||
| * Sponsor(s): TBD | ||
| * Review Manager: [Logan Wright](https://github.com/loganwright) | ||
| * Status: **Implemented** |
There was a problem hiding this comment.
Suggested change
| * Status: **Implemented** | |
| * Status: **Active Review** (June 1 - June 12) |
tomerd
reviewed
May 27, 2020
|
|
||
| ## Detailed design | ||
|
|
||
| Already implemennted |
There was a problem hiding this comment.
We need a bit more details here, like what the different stages of the buildpack do (which swift command they run, what configuration options the users have, etc)
tomerd
reviewed
May 27, 2020
|
|
||
| * Proposal: SSWG-0012 | ||
| * Authors: [KyleF](https://github.com/kylef), [VZSG](https://github.com/vzsg) | ||
| * Sponsor(s): TBD |
There was a problem hiding this comment.
Suggested change
| * Sponsor(s): TBD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initiating the heroku buildpack pr for comments and discussion