Ignore the --testing-library argument we are going to start passing from SwiftPM.
#490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from SwiftPM. This PR adds functionality to XCTest's argument parser that allows it to skip arguments that the caller may specify but which are uninteresting to XCTest. Specifically, we are planning to start passing `--testing-library xctest` to the test runner process in order to disambiguate runs of XCTest from runs of Swift Testing, and we need to make sure this does not cause XCTest to run incorrectly. Resolves rdar://129695171.
|
@swift-ci please test |
grynspan
requested review from
MaxDesiatov,
briancroom,
bnbarham,
stmontgomery and
dennisweissmann
|
@swift-ci please test |
briancroom
approved these changes
Jun 12, 2024
| } | ||
|
|
||
| let arguments = ["main", "--testing-library=xctest", "--testing-library", "xctest", "\(String(reflecting: ArgumentParsingTestCase.self))/testSuccess", "--testing-library",] | ||
| XCTMain([testCase(ArgumentParsingTestCase.allTests)], arguments: arguments) |
There was a problem hiding this comment.
Should there be any checks on the output/result from this? Does this test fail (and how) without the product code change?
There was a problem hiding this comment.
The test checks the exit code of the process, which should be non-zero if argument parsing failed.
That's my read anyway—you know this code better than I do.
There was a problem hiding this comment.
Yeah, sure, makes sense from re-reading the code.
stmontgomery
approved these changes
Jun 12, 2024
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to XCTest's argument parser that allows it to skip arguments that the caller may specify but which are uninteresting to XCTest. Specifically, we are planning to start passing
--testing-library xctestto the test runner process in order to disambiguate runs of XCTest from runs of Swift Testing, and we need to make sure this does not cause XCTest to run incorrectly.Resolves rdar://129695171.