Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Fix JSClosure leak (#240)" #242

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Apr 12, 2024

Seems like something wrong is happening in https://github.com/swiftwasm/JavaScriptKit/actions/runs/8659623850. I need stress test this before re-landing this.

This reverts commit 8780e5f.

@kateinoigakukun kateinoigakukun marked this pull request as draft April 12, 2024 09:22
Copy link

Time Change: +114ms (1%)

Total Time: 9,319ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 19ms -4ms (19%) 👏
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 15ms -1ms
Serialization/JavaScript function call from Swift 99ms +2ms (1%)
Serialization/Swift Int to JavaScript with assignment 330ms +9ms (2%)
Serialization/Swift Int to JavaScript with call 939ms +8ms (0%)
Serialization/JavaScript Number to Swift Int 303ms -1ms
Serialization/Swift String to JavaScript with assignment 383ms -0ms
Serialization/Swift String to JavaScript with call 976ms -7ms (0%)
Serialization/JavaScript String to Swift String 3,622ms +96ms (2%)
Object heap/Increment and decrement RC 2,620ms +12ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 2ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

1 participant