Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft-fail integer conversion from JS values that are not representable #259

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

kateinoigakukun
Copy link
Member

Close #258

Copy link

github-actions bot commented Jul 31, 2024

Time Change: +419ms (4%)

Total Time: 9,712ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 20ms +1ms (6%) 🔍
Serialization/JavaScript function call through Wasm import with int 16ms +2ms (14%) ⚠️
Serialization/JavaScript function call from Swift 112ms +16ms (13%) ⚠️
Serialization/Swift Int to JavaScript with assignment 338ms +22ms (6%) 🔍
Serialization/Swift Int to JavaScript with call 980ms +52ms (5%) 🔍
Serialization/JavaScript Number to Swift Int 312ms +23ms (7%) 🔍
Serialization/Swift String to JavaScript with assignment 409ms +32ms (7%) 🔍
View Unchanged
Test name Duration Change
Serialization/Swift String to JavaScript with call 1,021ms +44ms (4%)
Serialization/JavaScript String to Swift String 3,784ms +167ms (4%)
Object heap/Increment and decrement RC 2,706ms +59ms (2%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 2ms

The line number in the diagnostic message was hardcoded but it was
changed in the previous commit.
@kateinoigakukun kateinoigakukun marked this pull request as ready for review July 31, 2024 03:48
@kateinoigakukun kateinoigakukun merged commit d7309e2 into main Jul 31, 2024
16 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/int-conversion branch July 31, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Int.construct(from:) can crash instead of return nil
1 participant