Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rewrite fan control #495

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[WIP] Rewrite fan control #495

wants to merge 5 commits into from

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Aug 3, 2024

Tired of fans going brr on boot or when you...start a YouTube video or something?

TODO

  • Write a real summary and rationale for these changes
  • Handle min duty
    • Replace functionality of SMOOTH_FANS_MIN
  • Evaluate if duty change is responsive enough to handle sudden heavy loads like compilation or gaming
    • Still provides enough heat dissipation?
  • Check fans work on suspend entry/exit
    • Handling for S0ix?
  • Move fan tables to per-board fan.c files
  • Track level in table instead of calculating on every interval?
    • Know whether it's moving up/down
    • Separate column for up/down temps?
  • Manual mode for system firmware/OS control of fans

Mitigate some fan noise by using a moving average instead of
instantaneous points for thermal logic.

Current logic is set to update every 250ms, so use 4 points to average
over 1s.

Signed-off-by: Tim Crawford <[email protected]>
Replace calculating the duty on every update with tracking the level in
the fan tables to use. A second temperature column is added to the table
to allow different curves for heating up and cooling down.

Signed-off-by: Tim Crawford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant