Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Version EC separately from SBIOS #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Jul 12, 2023

Stop setting the EC version to the SBIOS version so that the EC will use its real version.

The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed.

At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. (UEFI requires the firmware version be a 32-bit unsigned integer, which would simplify the comparison.)

Resolves: #434

@crawfxrd
Copy link
Member Author

This could be simplified by having the EC only support building a single version. That is, put everything in build/<model>/ (single version per model) or even just build/ (single version for a single model) instead of build/<model>/<version>/.

I don't expect that to affect anyone but me, since I regularly diff the *.asm and ec.mem files when building. But that's more of a convenience; I can just copy the build output somewhere else.

@crawfxrd crawfxrd force-pushed the ec-version branch 2 times, most recently from 365bc2d to 57a15b7 Compare October 3, 2023 18:24
@crawfxrd crawfxrd force-pushed the ec-version branch 2 times, most recently from f040cc9 to d002b8e Compare October 19, 2023 14:50
@crawfxrd crawfxrd marked this pull request as ready for review October 19, 2023 18:24
@crawfxrd crawfxrd requested review from a team October 19, 2023 18:24
@crawfxrd crawfxrd force-pushed the ec-version branch 2 times, most recently from e0d7fc3 to 738bb0b Compare October 20, 2023 21:43
jacobgkau
jacobgkau previously approved these changes Oct 20, 2023
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build and flash scripts seem to still be working as expected. Tried on an existing clone and a fresh clone of the repo on lemp10.

leviport
leviport previously approved these changes Feb 21, 2024
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected on a gaze16-3050.

leviport
leviport previously approved these changes Feb 29, 2024
The original rationale for having the EC version match the SBIOS version
was to ensure that compatible versions of each were installed. So we set
the EC version to the SBIOS version and always flash both of them, even
if only one actually changed.

At some point, a mechanism should be implemented that checks for a
minimum supported/compatible version. This would be comparable to the
LVFS MetaInfo's "requires" field.

Ref: f4f4d5b ("Build EC as a submodule, specifying version")
Signed-off-by: Tim Crawford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version EC separately
3 participants