Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch and other icons #585

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

philli-philip
Copy link

This pull request adds the assets and the linking needed to for better Fav icons, in particular:

  • Apple Devices, when the Page is saved as a link to the devices Home Screen and Touch Bar
  • Android Devices, when the Page is saves as a link to the devices Home Screen, additionally it sets the background-color of the browser if opened from a home screen.
  • Windows, when the pages is stored to the Metro tile View
  • Fav-icons in higher resolution

@vercel
Copy link

vercel bot commented May 13, 2023

@philli-philip is attempting to deploy a commit to the Technologiestiftung Team on Vercel.

A member of the Team first needs to authorize it.

@ff6347 ff6347 added the enhancement New feature or request label May 14, 2023
@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 9:19am

@dnsos
Copy link
Collaborator

dnsos commented May 15, 2023

Hey @philli-philip, thanks for the contribution! I will review the changes as soon as possible. Stay tuned, I'll get back to this.

Copy link
Collaborator

@dnsos dnsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @philli-philip, thanks again for the contribution. I've got a few questions that need clarification. Also, the design of the monochrome icons doesn't really match the feel of the color logo, see my comment below.

While it certainly makes sense to include these optimizations for different browsers/devices, I'm a bit hesitant of merging them without being able to preview them. Do you know of any way to preview them without merging? Or perhaps you could point me to a good resource that explains the usage of such assets?

<browserconfig>
<msapplication>
<tile>
<square150x150logo src="/images/mstile-150x150.png"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with the mstiles. How does it work that here it's only one of the images referenced, but you actually added 5 different sizes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I'll link them.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the filled logo doesn't really match the feel of the original logo. If only one color is permitted here (and for the white ones), it would make sense to leave the outlines of the original logo and remove the circular, light-green background.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try that as I would agree that this it is the closest to the brand. But for readability I then decided that a filled version of the logo would be more suitable. Here the comparison:

Apple-filled Apple Touch Bar and Pinned Tab with outlined Logo Apple-outlined Apple Touch Bar and Pinned Tab with filled Logo MS-tiles-filled Microsoft Tiles with filled Logo MS-tiles-outlined Microsoft Tiles with outlined Logo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for the very small iOS use cases we go with the solid version and for MS-Tiles we go with the outlined version as the icons are displayed in large enough size so the details of the icon are well visible.

href='/images/safari-pinned-tab.svg'
color='#5bbad5'
/>
<link rel='shortcut icon' href='/images/favicon.ico' />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this duplicating the definition in line 47?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row 40 to 42 add the icon for the Safari Pinned Tabs, but yes row 43 is duplicated. I will remove it.

@philli-philip
Copy link
Author

To explain how to test the assets let's start with the list of places I considered icons for:

  • Favicon
    The common Favicon used by browsers to display the icon within the tab
  • Pinned Tab
    Only in Safari for pinned tabs. Safari dropped the icon for normal tabs. Also used for the Touch Bar on Apple Laptops (but who still uses the Touch Bar?)
  • Touch Icon
    is used by Apple devices like iPhone, iPad when the user saves a website to the home screen and the website appears to be an App. Similar how a link on Microsoft can have a Desktop icon. also used
  • Android Icon
    used by Android based devices when the link to the website is saved on the home screen (similar to iOS). Based on the browserconfig.xml is allows to configure the browser to give more of an app feeling by setting background color and a dedicated splash icon.
  • Windows Metro
    When Microsoft introduced the Metra design they also added the support to save link as metro tiles. the file site.webmanifest defines the tile color and the assets for the 4 different tile sizes.

So what needs to be done to test 100%?

  • You need the Safari browser to test the "Pinned tab icon" by pinning the page, then the grey version should be shown. On visiting the page the icon should turn green.
  • and another browser of choice to test "Favicon". Just visit the page and the favicon should be shown (already implemented so only regression testing needed)
  • An iPhone to test the "Touch icon". Go to the page. Tap export and use the action "Add to Home screen". The Touch Icon should be used to add an "App" to the iPhone that open the website (without URL).
  • An Android phone to teest "Android Icon". Visit the page, add to home screen, touch the icon and the page should open (this time the icon will displayed on white background with the icon as splash screen (instead of the browser Icon)
  • A windows computer to test the MS-Tile. Browse the Website and "Pin to start". Open the Metro Starting panel and a new tile should appear.
  • Mac laptop to test the Touch Bar icon: With the safari browser and the website added to your favorites the TouchBar shows the website as an quickly accessable item.

This works not only with the production version but also with [Preview](Visit Preview) from Vercel in this case.

If needed I can add a couple of screenshots verifying that the icons work.

@julizet
Copy link
Member

julizet commented Jul 6, 2023

Thanks for you patience and contribution @philli-philip. I spoke with @dnsos and we agreed once more that the logo should be inline with the overall look and feel.

I tested the following browsers / devices:

  • ❌ Safari browser "pinned tab" shows the blue filled logo version
  • ❌ Safari browser "favicon" shows the blue filled logo version
  • ✅ Safari Browser "bookmark" aka. "favourites" shows the logo in the colours of Gieß den Kiez (green, light green, black)
  • ✅ iPhone touch icon shows the logo in the colours of Gieß den Kiez (green, light green, black)

So in turn it would be necessary to solely use either the "outlined logo" like you suggested or try to use the original logo if possible. We don't use any blue color in within the CI. Maybe using the light green might also work?

I wasn't able to test:

  • Microsoft tiles
  • Android Icon

but I suggest the same to either use solely the outlined logo or stick to the original one.

Let me know what you think.

 ✅ _Safari_BookmarksFavourites

 ✅ _iPhone_TouchIcon

❌_Safari_Favicon ❌_Safari_PinnedTab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants