-
Notifications
You must be signed in to change notification settings - Fork 45.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loading a2 rather than a0 #11187
base: master
Are you sure you want to change the base?
loading a2 rather than a0 #11187
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @Chen-Zhe @chaoyan1037 , PR having typo changes , Please approve in your free time.Thanks |
Hi @Chen-Zhe, @chaoyan1037, Could you please review the PR. Thank You |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of change comments, maybe update "load_movinet_from_hub('a2', 'stream', hub_version=3)" to be "load_movinet_from_hub('a0', 'stream', hub_version=3)" since the following section Export a Streaming Model to TensorFlow Lite for Mobile also use 'a0' as example.
@chaoyan1037 |
In the documentation that is provided for MoViNet tutorial, it says we will download MoViNet-A0-Stream. But In the code MoViNet-A2 is downloaded and used.