Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop EL8 support from our codebase #2106

Merged
merged 2 commits into from
Aug 15, 2024
Merged

drop EL8 support from our codebase #2106

merged 2 commits into from
Aug 15, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 9, 2024

No description provided.

puppet/data/osfamily/RedHat-8.yaml Outdated Show resolved Hide resolved
unless $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '8' {
stdlib::ensure_packages(['htop', 'iftop', 'screen'])
}
stdlib::ensure_packages(['htop', 'iftop', 'screen'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen is back in EL9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Which makes me wonder if the utility class is properly applied, as the EL9 boxen do not drop any errors but that should have been applied there already?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a very good chance I somehow missed this. It's supposed to be applied via the Foreman ENC because we don't have the admins in Hiera (for privacy reasons). #1789 was intended to solve that but as you can see, that's been open for a while.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, screen IS in EPEL. But we could also just take tmux from baseos?

(but the utility class is still not correctly applied)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add utility to the base config group, but that'd mean we need EPEL on all (EL) systems, which we today don't do.

@ekohl ekohl merged commit 3e19a58 into master Aug 15, 2024
2 checks passed
@ekohl ekohl deleted the drop-el8 branch August 15, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants