Fixes #37742 - Exclude rhn-client-tools for subman upgrade #10280
Conversation
danmyway
changed the title
| @@ -65,7 +65,7 @@ if ! [ -x "$(command -v subscription-manager)" ] ; then | |||
| else | |||
| echo "subscription-manager is already installed!" | |||
| <% if @subman_setup_scenario == 'registration' -%> | |||
| $PKG_MANAGER_UPGRADE subscription-manager > /dev/null 2>&1 | |||
| $PKG_MANAGER_UPGRADE --setopt=obsoletes=0 subscription-manager > /dev/null 2>&1 | |||
There was a problem hiding this comment.
| $PKG_MANAGER_UPGRADE --setopt=obsoletes=0 subscription-manager > /dev/null 2>&1 | |
| $PKG_MANAGER_UPGRADE --exclude=rhn-client-tools subscription-manager > /dev/null 2>&1 |
This approach seems to me a bit more directed. Using obsoletes=0 may cause unintended effects down the road if sub-man or any of its deps use obsoletes.
There was a problem hiding this comment.
Related: oamg/convert2rhel#1164 (comment)
There was a problem hiding this comment.
We already have this bit here:
Right now I haven't looked at it in detail, but this PR implies that the original suggestion was insufficient.
There was a problem hiding this comment.
The suggestion by @bocekm does indeed work more reliable. I'll address that in the PR.
There was a problem hiding this comment.
@ekohl, as far as I recall from my testing some time back removing rhn-client-tools before installing sub-man on OL 7 is not sufficient - yum says that sub-man is obsoleted by rhn-client-tools and goes ahead and installs rhn-client-tools instead of sub-man.
* rhn-client-tools obsoletes subscription manager, installation of subman rpm has the flag --setopt=obsoletes=0 set correctly to mitigate this, but the subsequent upgrade of subscription-manager rpm does not * add the --setopt=exclude=rhn-client-tools flag so rhn-client-tools does not get installed instead of upgrade of the subman Signed-off-by: Daniel Diblik <[email protected]>
danmyway
changed the title
--setopt=exclude=rhn-client-toolsduring an upgrade