Implement a default database URL #10296
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a default database URL, which is postgresql:// for production and postgresql:///foreman-$ENV otherwise. That means using a unix socket to connect to, which implies the username and doesn't need any password. When no database name is given (like in production) PostgreSQL assumes one that matches the username. By doing this, there is no need for a config/database.yml file which simplifies setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a default database URL, which is
postgresql://for production andpostgresql:///foreman-$ENVotherwise. That means using a unix socket to connect to, which implies the username and doesn't need any password. When no database name is given (like in production) PostgreSQL assumes one that matches the username.By doing this, there is no need for a config/database.yml file which simplifies setup.
I'm not sure if this is a good idea or not. It'll still be needed for remote DBs and in case you need to override the pool size. It does make development and testing easier.