Update RuboCop to 1.56.x #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2023
|
FYI: there is https://projects.theforeman.org/issues/35374 open as an issue. There I chose version 1.35.x. 1.28.x is the latest version to support Ruby 2.5, but if we move to 2.7+ I think it's safe to go with a newer version. At the time that was 1.35.x, but it's probably even safe to move to 1.48.x which is the current latest. |
|
@archanaserver When you get time, can you come back around to this and do the update to 1.35 (or if there is a newer latest) ? |
ekohl
reviewed
Aug 7, 2023
Added additional RuboCop cops and updated .rubocop_todo.yml to address various code quality issues in the smart-proxy project. The changes help improve code consistency.
|
@ekohl, could you please review this? |
ekohl
requested changes
Aug 25, 2023
theforeman-bot
added
Needs re-review
and removed
Not yet reviewed
Waiting on contributor
labels
ekohl
requested changes
Aug 30, 2023
theforeman-bot
added
Waiting on contributor
and removed
Waiting on contributor
Needs re-review
labels
|
@ekohl I looked into the failure but can't find the issue, can you help what is the issue here? https://ci.theforeman.org/blue/organizations/jenkins/smart-proxy-pr-test/detail/smart-proxy-pr-test/275/pipeline |
ekohl
reviewed
Sep 6, 2023
ekohl
reviewed
Sep 6, 2023
archanaserver
force-pushed
the
ruby-3
branch
from
a94d7bd
to
b24e16c
Compare
theforeman-bot
added
Needs re-review
Waiting on contributor
and removed
Waiting on contributor
labels
archanaserver
force-pushed
the
ruby-3
branch
from
b24e16c
to
995ba74
Compare
Bumped the RuboCop version from 1.28.0 to 1.56.0 to ensure the project benefits from the latest improvements, bug fixes, and code analysis features provided by the updated RuboCop release.
archanaserver
force-pushed
the
ruby-3
branch
from
995ba74
to
bcf15ad
Compare
ekohl
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the RuboCop version from 1.28.0 to 1.56.0.
Requires:
The following PRs were reviewed and adjusted to ensure compatibility with the updated RuboCop/Ruby version:
For the rest of the smart-proxy plugins (
ansible,openscap,dhcp_infoblox,dhcp_remote_isc,discovery,dns_infoblox,pulp), no changes were required to support Ruby v3.