Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input checks for vfold_cv.R #548

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Update input checks for vfold_cv.R #548

merged 4 commits into from
Sep 23, 2024

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Sep 20, 2024

Focusing on

The last commit of reordering snapshot tests has messed a little with the overall diffs. Review commit-by-commit might be a little nicer!

R/vfold.R Show resolved Hide resolved
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuuuuuuup yup yup!🪴

R/vfold.R Show resolved Hide resolved
R/vfold.R Show resolved Hide resolved
@hfrick hfrick merged commit bf70b7b into main Sep 23, 2024
12 checks passed
@hfrick hfrick deleted the checks-vfold branch September 23, 2024 13:54
Copy link

github-actions bot commented Oct 8, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants