Retain widget settings through switches and closes #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the following: - add a dock - select a different widget - change some settings - close that dock - add a new dock - new dock has the widget and settings of the one previously closed Previous widget selections are kept on a stack, so this allows "new dock" to undo multiple previous "close" actions. Caveat being that if multiple instances of the same widget were closed, only the most recent one's settings will be kept. This isn't persisted at close, yet.
So, you can switch back and forth between differnet widgets without reverting their settings back to default. This state being kept at the DockManager means most recent settings become available to other docks, which makes "moving" a widget convenient. Still not persisted at application close ;)
So, the features introduced in the previous two patches now have persistent state through multiple runs of the application.
celeste-sinead
force-pushed
the
restore_docks
branch
from
51e5c37
to
b7f51c5
Compare
|
This is great @celeste-sinead, thanks. I think this would nicely complemented with a "reset" button on each settings widget to easily go back to the defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall, the intent is to make it more convenient to switch back and forth between widgets, or to temporarily show and then hide a widget, by not reverting widgets to default settings when doing this. More specifically: