Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use dep:valuable syntax instead of renaming valuable #3030

Open
wants to merge 2 commits into
base: v0.1.x
Choose a base branch
from

Conversation

davidbarsky
Copy link
Member

This syntax is a bit newer, but falls under tracing's MSRV. It also helps resolve some Buck vendoring nonsense at work.

@davidbarsky davidbarsky requested review from hawkw and a team as code owners July 12, 2024 18:54
@davidbarsky
Copy link
Member Author

I'll make a PR for master; I just need it on v0.1.x to unblock a thing.

Copy link

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants