Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix applyLazyDecorator return when metadataList is empty #30

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

smilecc
Copy link
Contributor

@smilecc smilecc commented Dec 19, 2023

Overview

I noticed that due to this commit of f319395, when the applyLazyDecorator method checks that methodNames does not meet the conditions, it will return the current check function, even if other methods meet the conditions.

This may be because the return code was copied from forEach.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@WhiteKiwi
Copy link
Member

Thank you for your contribution

@WhiteKiwi WhiteKiwi merged commit 09ff7fe into toss:v2.x Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants