feat(next-app-router) implement an adapter for next-app-router #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement an adapter for next-app-router for the issue discussed in #59.
Related Issue : #59
Context
Currently implemented to operate similarly to @use-funnel/browser. Used for history.state. context, history
useSearchParams in next.js requires suspense, you must wrap suspense when using useFunnel.
How Has This Been Tested
I tested locally whether the value was maintained through history.state even when refreshed.
I checked in the local environment whether the funnel steps were changed appropriately even when using the browser's back and forward functions.
Added test case for funnel.render.overlay.
I tested whether pages using useFunnel could be built without problems.
Further Comments
I look forward to app router users being able to use use-funnel too!
If there is anything else that needs correction, please let me know at any time.
thank you