Remove Lazy for Scala 2.13

[cchantep]

Lazy is not only not required for Scala 2.13, but it raised warnings (see typelevel/doobie#1513 ).

Removing it only for Scala 2.13 using cross version compatiblity.

[cchantep]

@pomadchin early push for feedback. I plan to apply in other required places in frameless.

[pomadchin]

@cchantep hmmm but why do we need this change? 🤔 Lazy is not needed in 2.13?

UPD: ooh, i see https://docs.scala-lang.org/sips/byname-implicits.html; should not it be replaced with by-name implicits (i'm just checking scala/scala#6050)?

[cchantep]

@cchantep hmmm but why do we need this change? 🤔 Lazy is not needed in 2.13?

UPD: ooh, i see https://docs.scala-lang.org/sips/byname-implicits.html; should not it be replaced with by-name implicits (i'm just checking scala/scala#6050)?

The tests confirm that what fails without Lazy in Scala 2.13- is working without.

[codecov]

Codecov Report

Merging #660 (5ab2e3c) into master (a27b04b) will increase coverage by 0.39%.
The diff coverage is 98.56%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   95.00%   95.39%   +0.39%     
==========================================
  Files          65       71       +6     
  Lines        1180     1281     +101     
  Branches       37       34       -3     
==========================================
+ Hits         1121     1222     +101     
  Misses         59       59              

Flag	Coverage Δ
2.12.16	?
2.12.17	95.00% <97.22%> (?)
2.13.10	95.59% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../src/main/scala/frameless/RecordEncoderField.scala	88.88% <ø> (ø)
...ataset/src/main/scala/frameless/TypedEncoder.scala	98.02% <ø> (+0.62%)	⬆️
dataset/src/main/scala/frameless/ops/As.scala	100.00% <ø> (ø)
...ain/scala-2.13-/frameless/TypedEncoderCompat.scala	96.20% <96.20%> (ø)
...src/main/scala-2.13+/frameless/RecordEncoder.scala	100.00% <100.00%> (ø)
...ain/scala-2.13+/frameless/TypedEncoderCompat.scala	100.00% <100.00%> (ø)
...main/scala-2.13+/frameless/ops/LowPriorityAs.scala	100.00% <100.00%> (ø)
...src/main/scala-2.13-/frameless/RecordEncoder.scala	100.00% <100.00%> (ø)
...main/scala-2.13-/frameless/ops/LowPriorityAs.scala	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[cchantep]

👋 @pomadchin rebased/all ✅

[pomadchin]

@cchantep yo! I'll take a look a bit later 💭

My main concern is that we're adding some code + language specific subdirs just to get rid of warning that can be (?) muted in the client app via a compiler flag. Is the same approach used in circe?

[cchantep]

@cchantep yo! I'll take a look a bit later 💭

My main concern is that we're adding some code + language specific subdirs just to get rid of warning that can be (?) muted in the client app via a compiler flag.

I don't see what you mean.
Once the frameless artifact built for one specific Scala version, there is nothing that can be skipped or disabled on the caller side.

Is the same approach used in circe?

That's how it's done a many project.

[pomadchin]

@cchantep

I don't see what you mean.

How to reproduce the behavior to see what is changed / what we're fighting here?

That's how it's done a many project.

My comment is not about cross scala builds, but about the Lazy usage. Is there a similar problem in i.e. circe codecs derivation (just the first thing that came to my mind with the Lazy usage)?

[pomadchin]

About the compiler flag, i've been referring to the scala/bug#12072 (comment)

[cchantep]

About the compiler flag, i've been referring to the scala/bug#12072 (comment)

That's not specific to this PR and we cannot do anything about.

[pomadchin]

@cchantep so how to reproduce the behavior to see what is the problem solved in this PR? I haven't faced Lazy being a problem in the other projects with frameless as a dep.