Experimental sdk-trace module
#325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
commented
Oct 1, 2023
sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/ReadWriteSpan.scala
Outdated
Show resolved
Hide resolved
iRevive
commented
Oct 1, 2023
sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkSpanBackend.scala
Outdated
Show resolved
Hide resolved
iRevive
commented
Oct 1, 2023
| import org.typelevel.otel4s.trace.SpanContext | ||
| import org.typelevel.otel4s.trace.Tracer | ||
|
|
||
| final class SdkTracer[F[_]: Concurrent: Clock] private[trace] ( |
There was a problem hiding this comment.
Nearly identical to the TracerImpl in the java module. The different part is:
def spanBuilder(name: String): SpanBuilder[F] =
new SdkSpanBuilder[F](name, scopeInfo, sharedState, scope)
iRevive
commented
Oct 1, 2023
| import scala.concurrent.duration._ | ||
|
|
||
| // Tree-like representation of a span | ||
| final case class SpanNode( |
There was a problem hiding this comment.
Copy-pasted from the java module
iRevive
commented
Oct 1, 2023
| import org.typelevel.otel4s.sdk.trace.exporter.BatchSpanProcessor | ||
| import org.typelevel.otel4s.sdk.trace.exporter.InMemorySpanExporter | ||
|
|
||
| object TraceSdkExample extends IOApp.Simple { |
There was a problem hiding this comment.
A fully functional example
iRevive
commented
Oct 1, 2023
sdk/common/src/main/scala/org/typelevel/otel4s/sdk/context/propagation/TextMapPropagator.scala
Outdated
Show resolved
Hide resolved
iRevive
commented
Oct 1, 2023
|
|
||
| object instances { | ||
| // We hope this instance is moved into Cats Effect. | ||
| implicit def localForIoLocal[F[_]: MonadCancelThrow: LiftIO, E](implicit |
There was a problem hiding this comment.
Copy-pasted from the java module
iRevive
commented
Oct 1, 2023
| if (attributes.isEmpty) Applicative[F].unit | ||
| else | ||
| mutableState.update { s => | ||
| s.copy(attributes = s.attributes |+| Attributes(attributes: _*)) |
There was a problem hiding this comment.
The spanLimits should be applied here.
To make it work, we should also tweak the implementation of the Attributes class.
iRevive
commented
Oct 1, 2023
sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkSpanBackend.scala
Outdated
Show resolved
Hide resolved
# Conflicts: # sdk/common/src/main/scala/org/typelevel/otel4s/sdk/autoconfigure/AutoConfigure.scala # sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/autoconfigure/SamplerAutoConfigure.scala
# Conflicts: # sdk-exporter/trace/shared/src/test/scala/org/typelevel/otel4s/sdk/exporter/otlp/trace/autoconfigure/OtlpSpanExporterAutoConfigureSuite.scala
# Conflicts: # sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/autoconfigure/SpanExportersAutoConfigure.scala
# Conflicts: # sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkTracerProvider.scala # sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/autoconfigure/TracerProviderAutoConfigureSuite.scala
# Conflicts: # build.sbt # sdk/all/src/main/scala/org/typelevel/otel4s/sdk/OpenTelemetrySdk.scala # sdk/all/src/test/scala/org/typelevel/otel4s/sdk/OpenTelemetrySdkSuite.scala # sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkTracerBuilder.scala # sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SdkTraces.scala # sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/SdkTracesSuite.scala
|
Almost all changes from this branch exist in the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an experimental
sdk-tracemodule fully written in Scala.Most of the design decisions were based on the Java implementation, and some can be reconsidered.
Currently, there is only
InMemoryExporterbut it's enough to run tests on Scala Native and ScalaJS platforms.I've copy-pasted the
TracerSuitefrom Java module and all tests pass.All other cases work as expected:
W3CTraceContextPropagator)W3CTraceContextPropagator)PasstroughPropagator)Current scope:
private,private[trace], etcW3CTraceContextPropagatorcoreandsdkAPI. e.g. sdk should useTextMapPropagatorfrom coreNext steps: