Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] pgx v5 #25

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[WIP] pgx v5 #25

wants to merge 13 commits into from

Commits on Oct 24, 2023

  1. chore: Deps

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1827ee9 View commit details
    Browse the repository at this point in the history

  2. fix: Use pgx v5 TraceLogger pattern

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    55d032b View commit details
    Browse the repository at this point in the history

  3. chore: Upgrade linter

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    754cb82 View commit details
    Browse the repository at this point in the history

  4. chore: Ignore deprecated linters

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    34c0290 View commit details
    Browse the repository at this point in the history

  5. test: Use require, not assert, for error checking 

    require-error: for error assertions use require (testifylint)
    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7fd5b19 View commit details
    Browse the repository at this point in the history

  6. test: Faster int to string conversion 

    fmt.Sprintf can be replaced with faster strconv.Itoa (perfsprint)
    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    14a6d3e View commit details
    Browse the repository at this point in the history

  7. chore: Don't use depguard linter

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9da5d7a View commit details
    Browse the repository at this point in the history

  8. fix: Remove unused params

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6255e5d View commit details
    Browse the repository at this point in the history

  9. fix: Remove always-nil error return 

    Output from linter:
(Config).runTestQueriesOnTarget - result 1 (error) is always nil (unparam)
    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    57e2487 View commit details
    Browse the repository at this point in the history

  10. chore: Ensure interface param is named 

    Linter error:
interface method apply must have all named params (inamedparam)
    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    650d77b View commit details
    Browse the repository at this point in the history

  11. ci: Use go1.21

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    40af68f View commit details
    Browse the repository at this point in the history

  12. ci: Use go container for unit tests

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c03afda View commit details
    Browse the repository at this point in the history

  13. ci: Install go1.21 on vm

    @cjfinnell
    cjfinnell committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ec233dd View commit details
    Browse the repository at this point in the history