Feature/trigger matching + double counting #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds trigger object matching and cross cleaning between different data streams.
To achieve the trigger object matching, the trigger Selector has been reimplemented using a newly created
Trigger
collection from the config.The strategy for the cross cleaning is as follows:
priority data stream fires, the event is removed
Our data stream priority is data_mu>data_egamma>data_muoneg. Therefore events are kept as follows:
This means that we can (and need to) run over all data streams independent of the lepton channel when creating data/mc plots.
Currently, the trigger selection simply uses all triggers that are present in the
cfg.x.triggers
collection. To customize our dl selector, we can overwrite thetrigger_config_func
attribute viaderive
, which is a function that can modify the config during the init call of our selector.TODO: we still need to implement these new selectors in the sl selector.