Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flp navigation recipe #380

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove flp navigation recipe #380

wants to merge 2 commits into from

Conversation

Siolto
Copy link
Collaborator

@Siolto Siolto commented Nov 24, 2022

How we currently suggest to navigate in the FLP is more of a bad practice than a good one. In my opinion there are 3 better ways to do that:

  • use the full link in the baseUrl to your application (with semantic object and action). That way you save also time while not waiting for the launchpad to load.

If you really want to start with a launchpad:

  • use the wdi5.goTo("#semanticObject-action") function to navigate to one specific application in the launchpad

If you really want to identify the tile via wdi5:

  • use the full capabilities of the matchers combined:
await browser.asControl({
  selector: {
    controlType: "sap.ushell.ui.generic.Tile",
    descendant: {
      controlType: "sap.m.Text",
      properties: {
        text: 'text'
      } 
    }
  }
}

All three ways are better than our current one where we suggest to programmatically navigate the control tree up.

@vobu
Copy link
Contributor

vobu commented Nov 24, 2022

with you on the not-so-good practice of FLP navigation...but I'd favor the above to be in the recipes rather than just deleting the section.
all pro code-deletion, but not for docs 😝

@vobu
Copy link
Contributor

vobu commented Jan 16, 2023

re-pinging you @Siolto for your opinion on rather updating the recipe with your (excellent!) suggestion than deleting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants