fix: popover opening with new slot syntax and no title/content #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or enhancement? - bug fix
Hello again! 👋
Once again, I appreciate all the hard work that's gone into this project. We're still happily using version 1. 😊
As we transitioned away from deprecated Vue slot syntax, we discovered some nuances with the popover component.
The Fix
The issue revolved around the
isNotEmptymethod. Previously, it checked forthis.$slots.popover, which was causing problems with the latest Vue slot syntax. To address this, I've updated it tothis.$scopedSlots.popover. This ensures that the popover functions as expected with the updated syntax. I've also added a unit test to cover this specific use case.Is there a related issue?
None at this time.
Any Breaking Changes?
No breaking changes are introduced by this PR.