V14: Refactor LogViewerService #14511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into v14/feature/refactor-logviewer # Conflicts: # src/Umbraco.Infrastructure/Services/Implement/LogViewerService.cs
elit0451
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Serilogfrom LogViewerServiceILogViewerRepositorythat now handles the getting of the logs (if you wanted to swap out serilog, you theoretically could at least from the logviewer respective now, by implementing your own ILogViewerRepository)LogViewerRepositoryclassWhile I would love to refactor the whole Serilog stuff, I think this should work wonders for now, and we at least have all the infrastructure code, out of our core services 💪
How to test
Query the different log endpoints, they should still work 🤞