Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for checking if settings model contains default value #14513

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Added test for checking if settings model contains default value #14513

merged 4 commits into from
Jul 10, 2023

Conversation

andr317c
Copy link
Contributor

@andr317c andr317c commented Jul 6, 2023 •
edited
Loading

Added tests for checking if the block list editor settings model contains the defined default value.

Also did some cleaning up on blockListEditorContent file

The test was created so we would be able to see if we run into this issue again: #13134

Zeegaan
Zeegaan requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things 😁

...raco.Tests.AcceptanceTest/tests/DefaultConfig/BlockListEditor/blockListEditorContent.spec.ts Outdated Show resolved Hide resolved
...raco.Tests.AcceptanceTest/tests/DefaultConfig/BlockListEditor/blockListEditorContent.spec.ts Outdated Show resolved Hide resolved
@andr317c
Merge remote-tracking branch 'origin/v12/dev' into v12/QA/added-block…
ee90695 
…-list-settings-model-test

# Conflicts:
#	tests/Umbraco.Tests.AcceptanceTest/package-lock.json
#	tests/Umbraco.Tests.AcceptanceTest/package.json
@andr317c
Moved createSliderWithDefaultValue function to our testHelpers. Remov…
d4d599d 
…ed the use of count in test since there was only one
Zeegaan
Zeegaan approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zeegaan Zeegaan merged commit 313fdf7 into v12/dev Jul 10, 2023
13 of 15 checks passed
@Zeegaan Zeegaan deleted the v12/QA/added-block-list-settings-model-test branch July 10, 2023 08:38
iOvergaard pushed a commit that referenced this pull request Sep 11, 2023
@andr317c @iOvergaard
Added test for checking if settings model contains default value (#14513
ca8ac21 
)

* Added test for checking if a settings model contains default value.
Fixed tests

* Bumped version

* Moved createSliderWithDefaultValue function to our testHelpers. Removed the use of count in test since there was only one
iOvergaard pushed a commit that referenced this pull request Sep 11, 2023
@andr317c @iOvergaard
Added test for checking if settings model contains default value (#14513
c42ca63 
)

* Added test for checking if a settings model contains default value.
Fixed tests

* Bumped version

* Moved createSliderWithDefaultValue function to our testHelpers. Removed the use of count in test since there was only one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpnielsen jdpnielsen jdpnielsen approved these changes

@Zeegaan Zeegaan Zeegaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andr317c @jdpnielsen @Zeegaan