-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile css for icons style #14615
Compile css for icons style #14615
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @bjarnef, 2 comments to resolve.
Other than that you noted:
In the block grid view we probably need to adjust the CSS to include cache buster
Please do yes!
Co-authored-by: Sebastiaan Janssen <[email protected]>
Co-authored-by: Sebastiaan Janssen <[email protected]>
Thanks @bjarnef this is looking good now, if you still want to adjust the cachebuster then I look forward to a new PR for it! 👍 |
@nul800sebastiaan the cache buster is adjusted in #14621 |
Prerequisites
If there's an existing issue for this PR then this fixes #14614
Description
When rendering icons inside
<umb-block-grid-root>
and<umb-block-grid-block>
it only rendered SVG icons and not legacy font icons likeicon-science
which doesn't have a SVG version here: https://github.com/umbraco/Umbraco-CMS/tree/contrib/src/Umbraco.Web.UI.Client/src/assets/iconsWe should probably also add
icon-science.svg
, but font icons are still supported and developers may still use custom font icons (font packages) although SVG icons are the modern approach.The PR also remove some redundant style if we sometime later need to adjust style of
<umb-icon>
component, this ensure icons in block grid are consistent.In the block grid view we probably need to adjust the CSS to include cache buster like here:
Umbraco-CMS/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blockgrid/umbblockgridroot.component.js
Line 39 in 71d9905