Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile css for icons style #14615

Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 30, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #14614

Description

When rendering icons inside <umb-block-grid-root> and <umb-block-grid-block> it only rendered SVG icons and not legacy font icons like icon-science which doesn't have a SVG version here: https://github.com/umbraco/Umbraco-CMS/tree/contrib/src/Umbraco.Web.UI.Client/src/assets/icons

We should probably also add icon-science.svg, but font icons are still supported and developers may still use custom font icons (font packages) although SVG icons are the modern approach.

The PR also remove some redundant style if we sometime later need to adjust style of <umb-icon> component, this ensure icons in block grid are consistent.

In the block grid view we probably need to adjust the CSS to include cache buster like here:

@import 'assets/css/blockgridui.css?umb__rnd=${Umbraco.Sys.ServerVariables.application.cacheBuster}';

image

@github-actions
Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Member

@nul800sebastiaan nul800sebastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @bjarnef, 2 comments to resolve.

Other than that you noted:

In the block grid view we probably need to adjust the CSS to include cache buster

Please do yes!

src/Umbraco.Web.UI.Client/src/less/belle.less Outdated Show resolved Hide resolved
src/Umbraco.Web.UI.Client/src/less/belle.less Outdated Show resolved Hide resolved
@nul800sebastiaan nul800sebastiaan merged commit 88c35e9 into umbraco:contrib Jul 31, 2023
13 checks passed
@nul800sebastiaan
Copy link
Member

Thanks @bjarnef this is looking good now, if you still want to adjust the cachebuster then I look forward to a new PR for it! 👍

@bjarnef bjarnef deleted the bug/block-grid-legacy-font-icons branch July 31, 2023 21:44
@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 1, 2023

@nul800sebastiaan the cache buster is adjusted in #14621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icon-science invisible in the Block Grid Editor in the backoffice
2 participants