-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing list view usages to data type references (#14485) #14617
Conversation
Hi there @ustadstar, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ustadstar - we'll have a better look soon, but to begin with I've left you a comment to update the interface so it's not a breaking change.
src/Umbraco.Core/Persistence/Repositories/IDataTypeRepository.cs
Outdated
Show resolved
Hide resolved
@nul800sebastiaan I have added a default implementation for both methods in the interfaces. |
Hi @nul800sebastiaan, did you have time to review the changes? |
Hey, @ustadstar! I thought I'd jump in here and review this PR 😄 Thanks a lot for making those change requests, I have tested this PR and everything looks good to me, therefore I have merged this one in! Thanks for fixing #14485 🚀 You'll see this in the next release. |
Great stuff all! |
Prerequisites
If there's an existing issue for this PR then this fixes #14485
Please see the issue for the description of the bug including the steps to reproduce.
My changes do show the content types which use a list view as a container under references on the info tab of a datatype. However my changes are not the ideal solution to the problem. A better solution for the future would be a change in the database schema to add a relation between the list view (the isContainer field on contentType is now a boolean, without any relation).
My solution finds the relation between the datatype and list views as a container as follows:
To test this PR please follow the steps below.
Test with a default list view
Test with a custom list view