Fixed incorrect assignment of Last Login Date after a user accepts an invite and sets the password

[miguelcrpinto]

Prerequisites

• I have added steps to test this contribution in the description below

This fixes 14612

Description

Updated the PostSetInvitedUserPassword in the CurrentUserController to assign the Last Login Date to the correct property.

I tried to keep the changes to the minimum. But this could be improved (sparing a call to _backOfficeUserManager.UpdateAsync) if we move the assignments of the IsApproved and LastLoginDateUtc to the line before the _backOfficeUserManager.AddPasswordAsync. (I did not try this improvement proposal but I checked and the AddPasswordAsync method only updates the user after the set password is successful)

Let me know if you'd like me to apply and test the suggested improvement.

Steps to reproduce

To test, please follow the steps in the original issue. I followed those steps locally and I was able to reproduce the issue locally (Windows time zone: CEST (UTC + 2))

[github-actions]

Hi there @miguelcrpinto, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nul800sebastiaan]

Thanks @miguelcrpinto - looks good to me! I can confirm that the before and after actually work, user test2 logged in at 10:10 PM and not 8:10 PM, so it was displayed wrong. Updating the code and making a new test3 user showed that the logged in time was correct.

[miguelcrpinto]

@nul800sebastiaan in the original issue it mentioned V10.6.1. Would be nice to cherry pick and include in an upcoming V10 release

[nul800sebastiaan]

We go through cherry picking for other versions at a later stage, at which point this PR will be updated with related info. 👍