Support parentId in document/media item search endpoints #16933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migaroez
changed the title
|
Does it make sense to update version number? I know it is logically correct, but does it bring any value, compared to just allowing one more optional parameter in the existing endpoint? If - And only if - we stay with v1.1 then v1 should be obsoleted imo. |
bergmania
requested changes
Aug 27, 2024
src/Umbraco.Cms.Api.Management/Controllers/Media/Item/SearchMediaItemController.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/Controllers/Document/Item/SearchDocumentItemController.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/Controllers/Document/Item/SearchDocumentItemController.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/Controllers/Media/Item/SearchMediaItemController.cs
Outdated
Show resolved
Hide resolved
bergmania
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The document/media item search endpoints need to be enhanced with the ability to limit the search results based on the parentId for certain pickers to work better.
Testing
Setting up a multi layer content structure (root-parents-children) and querying the updated endpoint with one of the parent ids should only return (some) of that parent's children.
Leaving out the parentId should work just like the old endpoint.