Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15: Fix previews #17181

Merged
merged 3 commits into from
Oct 3, 2024
Merged

V15: Fix previews #17181

merged 3 commits into from
Oct 3, 2024

Conversation

bergmania
Copy link
Member

@bergmania bergmania commented Oct 3, 2024 •
edited
Loading

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #17175

Description

Fixes previews. The underlying problem was the the cache defaulted to non-draft, but must default to lookup in the preview service.

Tests

  • Use the preview functionality. Ensure, while you have a valid preview cookie, you get preview content, otherwise published content

Breaking Changes

  • Had to change some signatures from bool to bool?

@bergmania bergmania changed the base branch from contrib to release/15.0 October 3, 2024 10:49
@bergmania bergmania requested a review from Zeegaan October 3, 2024 10:50
Zeegaan
Zeegaan approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good 🚀

@Zeegaan Zeegaan merged commit 537a657 into release/15.0 Oct 3, 2024
15 checks passed
@Zeegaan Zeegaan deleted the v15/hotfix/17175-previews branch October 3, 2024 13:35
@Zeegaan Zeegaan mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeegaan Zeegaan Zeegaan approved these changes

Assignees
No one assigned
Labels
category/breaking release/15.0.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v15RC1: Previews a broken
2 participants
@bergmania @Zeegaan