Tweak platform conditional in patch to support cross builds #2816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
disable-domain-reliability.patch
, a conditional block is added to allow a script in thedomain_reliability
component to accept a null device as input (NUL
on Windows,/dev/null
on Linux).However, the condition is predicated on
is_win
, which translates to "is this build for Windows?" When I cross-compile ungoogled-chromium on Linux for Windows, I get this:This PR changes the condition to
host_os == "win"
(i.e. "are we building on Windows?"), which I believe is what was intended. This allows the cross build to succeed.