Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: nixos.md: Corrected to showcase module usage #20413

Merged
merged 1 commit into from
May 1, 2024
Merged

doc: nixos.md: Corrected to showcase module usage #20413

merged 1 commit into from
May 1, 2024

Conversation

jpds
Copy link
Contributor

@jpds jpds commented May 1, 2024

Fixed NixOS page to show module usage.

@jpds jpds requested review from a team as code owners May 1, 2024 21:07
jhgilbert
jhgilbert reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions, please re-request a review when it's ready for another look. Thank you!

website/content/en/docs/setup/installation/operating-systems/nixos.md Outdated Show resolved Hide resolved
website/content/en/docs/setup/installation/operating-systems/nixos.md Outdated Show resolved Hide resolved
website/content/en/docs/setup/installation/operating-systems/nixos.md Outdated Show resolved Hide resolved
jszwedko
jszwedko approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpds !

@jszwedko jszwedko requested a review from jhgilbert May 1, 2024 21:51
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 1, 2024
@jszwedko jszwedko enabled auto-merge May 1, 2024 22:18
@jszwedko jszwedko added this pull request to the merge queue May 1, 2024
Merged via the queue into vectordotdev:master with commit 7f46231 May 1, 2024
50 of 52 checks passed
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
@jpds @AndrooTheChen
doc: nixos.md: Corrected to showcase module usage (vectordotdev#20413)
7627f01 
doc: nixos.md: Corrected to showcase module usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@jhgilbert jhgilbert jhgilbert approved these changes

Assignees
No one assigned
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpds @jszwedko @jhgilbert