Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): component features comment trigger one runner label #20430

Merged
merged 1 commit into from
May 3, 2024
Merged

fix(ci): component features comment trigger one runner label #20430

merged 1 commit into from
May 3, 2024

Conversation

neuronull
Copy link
Contributor

Since GH only supports one runner label we recently updated our workflows but missed one- the component features when run on demand via comment trigger.

@neuronull neuronull self-assigned this May 3, 2024
@neuronull neuronull added no-changelog Changes in this PR do not need user-facing explanations in the release changelog domain: ci Anything related to Vector's CI environment labels May 3, 2024
@github-actions github-actions bot removed the domain: ci Anything related to Vector's CI environment label May 3, 2024
@neuronull neuronull marked this pull request as ready for review May 3, 2024 20:55
@neuronull neuronull enabled auto-merge May 3, 2024 21:01
pront
pront approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix

@neuronull neuronull added this pull request to the merge queue May 3, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: neuronull/ci_fix_comp_features_runs_on
Commit report: 11eb580
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.48s Wall Time

Merged via the queue into master with commit c2765f4 May 3, 2024
54 of 56 checks passed
@neuronull neuronull deleted the neuronull/ci_fix_comp_features_runs_on branch May 3, 2024 22:29
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
@neuronull @AndrooTheChen
fix(ci): component features comment trigger one runner label (vectord…
2afddcf 
…otdev#20430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@pront pront pront approved these changes

Assignees

@neuronull neuronull

Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neuronull @jszwedko @pront