feat(watcher): add support for poll watcher #21290
Conversation
|
|
amribm
force-pushed
the
feature/support_for_poll_watcher
branch
from
3773b14
to
ae66312
Compare
amribm
force-pushed
the
feature/support_for_poll_watcher
branch
from
4c926d0
to
1802ece
Compare
amribm
changed the title
| } | ||
| WatcherConfig::PollWatcher(interval) => { | ||
| let config = | ||
| notify::Config::default().with_poll_interval(Duration::from_secs(*interval)); |
There was a problem hiding this comment.
Should we allow the user to specify compare_contents? https://docs.rs/notify/latest/notify/struct.Config.html#method.with_compare_contents
maybe another argument? Im afraid we are adding too much arguments for this though
There was a problem hiding this comment.
I'd vote against it being user controllable and hope for it to just have a sane default. I can't think of a scenario where I'd wanna toggle it!
There was a problem hiding this comment.
We found issues in openshift environments where the inotify watcher was constantly triggered and the file contents did not change at all. In this case, we would like to hash the contents to check if it really changed before reloading vector config. I think having sane defaults is good (for example, this would default to false), but there are situations where this is useful
There was a problem hiding this comment.
Would there be a downside to always hashing the changes?
There was a problem hiding this comment.
Yes, as the docs I pointed states:
By enabling this feature, performance will be significantly impacted as all files will need to be read and hashed at each poll_interval.
I prefer that downside to be opt-in
There was a problem hiding this comment.
IMO it is a reasonable opt-in option that we can include in this PR. To be clear, I don't feel strongly about adding it here and now.
Co-authored-by: Jorge Hermo <[email protected]>
|
Hey @amribm, thank you for this PR!
|
|
okay, i will add changelog
Yes This is ready for review , @pront i need some confirmation from vector team for those comments. that's why i didn't resolved them. |
| } | ||
| WatcherConfig::PollWatcher(interval) => { | ||
| let config = | ||
| notify::Config::default().with_poll_interval(Duration::from_secs(*interval)); |
There was a problem hiding this comment.
IMO it is a reasonable opt-in option that we can include in this PR. To be clear, I don't feel strongly about adding it here and now.
Co-authored-by: Pavlos Rontidis <[email protected]>
Co-authored-by: Pavlos Rontidis <[email protected]>
Co-authored-by: Pavlos Rontidis <[email protected]>
… and docs update
github-actions
bot
added
the
domain: external docs
Closes #21111