-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(axiom sink): Rebase sink on http
sink and remove elasticsearch
compatibility
#21362
Open
darach
wants to merge
10
commits into
vectordotdev:master
Choose a base branch
from
darach:vector-axiom-sink-rebase-http
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vectordotdev#21292 Signed-off-by: Darach Ennis <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
github-actions
bot
added
domain: sinks
Anything related to the Vector's sinks
domain: external docs
Anything related to Vector's external, public documentation
labels
Sep 26, 2024
Signed-off-by: Darach Ennis <[email protected]>
…ection to changelog entry Signed-off-by: Darach Ennis <[email protected]>
drichards-87
approved these changes
Sep 26, 2024
jszwedko
reviewed
Sep 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @darach ! I'll aim to review this next week.
Signed-off-by: Darach Ennis <[email protected]>
…toml Signed-off-by: Darach Ennis <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
Signed-off-by: Darach Ennis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain: external docs
Anything related to Vector's external, public documentation
domain: sinks
Anything related to the Vector's sinks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21292
The
axiom
sink has been rebased fromelasticsearch
tohttp
per the issue.Deprecated headers removed in favor of aligning with the
http
request
configurationscope, and the
compression
configuration now defaults togzip
.The sink now conforms to Axiom's native ingest API:
https://axiom.co/docs/send-data/ingest#ingest-api
The
_time
field vector event data is no longer rejected. This was a source ofconfusion for vector axiom users in the past as
elasticsearch
semantics wereimposed as the sink was based on the
elasticsearch
sink and hence fieldsemantics and constraints.
For existing vector users, the
_time
field is documented and aligns well withvectors own timestamp mechanics:
https://axiom.co/docs/reference/field-restrictions#requirements-of-the-timestamp-field
If a
@timestamp
field is sent to the axiom sink it is now treated as a normal field. Thisis a non breaking change.
If a
_time
field is sent to Axiom it no longer raises a 4XX error, so this is effectively a fix.As the
axiom
sink is now HTTP based the full wealth of vectors http configuration apparatusare now available to users of the axiom sink.