Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(nats source): add support for multiple URLs #21386

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

benjamin-awd
Copy link
Contributor

This PR adds support for specifying multiple URLs in the NATS source.

I decided to take the same approach as core NATS, which is to pass a string containing comma separated URLS, which feels slightly more idiomatic than attempting to support both an optional string/vector input.

Closes #21385

@benjamin-awd benjamin-awd requested review from a team as code owners September 30, 2024 09:16
@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: external docs Anything related to Vector's external, public documentation labels Sep 30, 2024
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @benjamin-awd !

auto-merge was automatically disabled October 2, 2024 03:48

Head branch was pushed to by a user without write access

@jszwedko jszwedko added this pull request to the merge queue Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Regression Detector Results

Run ID: 1d71c3c5-56be-4ccd-84a1-0703233662d0 Metrics dashboard

Baseline: 3a13437
Comparison: 71bcf87

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -3.09 [-10.05, +3.87]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
otlp_http_to_blackhole ingress throughput +4.73 [+4.60, +4.87]
syslog_splunk_hec_logs ingress throughput +3.19 [+3.08, +3.31]
socket_to_socket_blackhole ingress throughput +3.06 [+3.00, +3.12]
splunk_hec_route_s3 ingress throughput +2.84 [+2.51, +3.16]
syslog_humio_logs ingress throughput +2.32 [+2.20, +2.45]
syslog_regex_logs2metric_ddmetrics ingress throughput +1.79 [+1.62, +1.95]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +1.31 [+1.20, +1.41]
syslog_log2metric_splunk_hec_metrics ingress throughput +1.27 [+1.16, +1.38]
fluent_elasticsearch ingress throughput +0.78 [+0.28, +1.28]
otlp_grpc_to_blackhole ingress throughput +0.70 [+0.59, +0.80]
syslog_loki ingress throughput +0.56 [+0.49, +0.62]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.19 [+0.01, +0.37]
http_to_http_noack ingress throughput +0.11 [+0.04, +0.17]
http_to_http_json ingress throughput +0.10 [+0.02, +0.17]
splunk_hec_indexer_ack_blackhole ingress throughput +0.01 [-0.07, +0.09]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.10, +0.09]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.10, +0.08]
http_to_s3 ingress throughput -0.12 [-0.39, +0.16]
http_text_to_http_json ingress throughput -0.22 [-0.35, -0.09]
syslog_log2metric_humio_metrics ingress throughput -0.40 [-0.53, -0.27]
http_to_http_acks ingress throughput -0.47 [-1.69, +0.75]
datadog_agent_remap_blackhole_acks ingress throughput -1.08 [-1.19, -0.98]
http_elasticsearch ingress throughput -1.56 [-1.69, -1.44]
datadog_agent_remap_blackhole ingress throughput -1.84 [-1.96, -1.73]
datadog_agent_remap_datadog_logs ingress throughput -1.88 [-2.07, -1.70]
file_to_blackhole egress throughput -3.09 [-10.05, +3.87]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into vectordotdev:master with commit 71bcf87 Oct 3, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple URL support for NATS source
3 participants