Skip to content

Commit

Permalink
Update snapshots p2
Browse files Browse the repository at this point in the history
  • Loading branch information
trungleduc committed Oct 3, 2024
1 parent 627fe7a commit 1fc480b
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 13 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,23 @@ jobs:
path: ./dist

install:
runs-on: ${{ matrix.os }}-latest
runs-on: ${{ matrix.os }}
needs: [build]
strategy:
fail-fast: false
matrix:
os: [ubuntu, macos-12, windows]
os: [ubuntu-latest, macos-12, windows-latest]
python: ['3.8', '3.10']
include:
- python: '3.8'
dist: 'voila*.tar.gz'
- python: '3.10'
dist: 'voila*.whl'
- os: windows
- os: windows-latest
py_cmd: python
- os: macos-12
py_cmd: python3
- os: ubuntu
- os: ubuntu-latest
py_cmd: python
steps:
- name: Install Python
Expand Down
2 changes: 1 addition & 1 deletion ui-tests/playwright.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = {
retries: 1,
expect: {
toHaveScreenshot: {
maxDiffPixelRatio: 0.025
maxDiffPixelRatio: 0.05
}
}
};
28 changes: 20 additions & 8 deletions ui-tests/tests/voila.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import { expect, test } from '@playwright/test';
import { addBenchmarkToTest } from './utils';

const PREFIX =
process.env.PROGRESSIVE_RENDERING === 'true' ? 'progressive_rendering_' : '';
const PROGRESSIVE_RENDERING = process.env.PROGRESSIVE_RENDERING === 'true';
const PREFIX = PROGRESSIVE_RENDERING ? '' : '';
test.describe('Voila performance Tests', () => {
test.beforeEach(({ page }) => {
page.setDefaultTimeout(120000);
Expand Down Expand Up @@ -310,19 +310,31 @@ test.describe('Voila performance Tests', () => {
const notebookName = 'query-strings';
const testFunction = async () => {
await page.goto(`/voila/render/${notebookName}.ipynb`);
await page.waitForSelector(
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
);
if (PROGRESSIVE_RENDERING) {
await page.waitForSelector(
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
);
} else {
await page.waitForSelector(
'div.jp-OutputArea-output[data-mime-type="text/plain"]'
);
}
const userName = await page.$$(
'div.jp-RenderedText.jp-OutputArea-output > pre'
);
expect(await userName[1].innerHTML()).toContain('Hi Kim');
};
await addBenchmarkToTest(notebookName, testFunction, testInfo, browserName);
await page.goto(`/voila/render/${notebookName}.ipynb?username=Riley`);
await page.waitForSelector(
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
);
if (PROGRESSIVE_RENDERING) {
await page.waitForSelector(
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
);
} else {
await page.waitForSelector(
'div.jp-OutputArea-output[data-mime-type="text/plain"]'
);
}
const userName = await page.$$(
'div.jp-RenderedText.jp-OutputArea-output > pre'
);
Expand Down
Binary file modified ui-tests/tests/voila.test.ts-snapshots/bokeh-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/tests/voila.test.ts-snapshots/gridspecLayout-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/tests/voila.test.ts-snapshots/voila-tree-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 1fc480b

Please sign in to comment.