Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a options template to localize algolia tool instructions #2758

Conversation

nazarepiedady
Copy link
Contributor

closes #2744

@Jinjiang, @posva, what do you think about these changes?

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit 93bf4d0
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/66faa19032a1000008196a41

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 93bf4d0
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/66faa190251e21000831f731
😎 Deploy Preview https://deploy-preview-2758--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nazarepiedady nazarepiedady marked this pull request as ready for review September 5, 2024 11:38
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add unused code. Instead, let's just mention this in the contribution guidelines. It should just mention the the type rather than a verbose code sample.

@posva posva merged commit 855510a into vuejs:v2 Sep 30, 2024
2 checks passed
Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/pinia@2758
pnpm add https://pkg.pr.new/@pinia/nuxt@2758
pnpm add https://pkg.pr.new/@pinia/testing@2758

commit: 93bf4d0

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (70d9b66) to head (93bf4d0).
Report is 18 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2758      +/-   ##
==========================================
- Coverage   91.23%   89.66%   -1.58%     
==========================================
  Files          14       14              
  Lines        1335     1335              
  Branches      233      218      -15     
==========================================
- Hits         1218     1197      -21     
- Misses        115      137      +22     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

docs: provide a DefaultTheme.AlgoliaSearchOptions['locales'] template for translators
2 participants