-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: webpack 5 support #397
Conversation
Also upgrade to use webpack@5, still an outstanding bug in applying updates with errors
Ready for review? |
I'm happy to take notes on this, but i'm not intending to merge until the fix (or an equivalent) to #394 is included - and I want to understand exactly what's changed before applying that fix. |
Would be nice to get this reviewed and merged. Even if it only fixes 80% of webpack 5 integration. |
Co-authored-by: Ward Peeters <[email protected]>
Does the "bugfix" checkbox in the PR description also cover documentation updates? I wouldn't consider out-of-date docs as a "bug", but each to their own... Also i second that this is important to expedite. |
any updates on when we could get the fixes release? |
The fix will be released when what changed in webpack 5 is understood and then a fix can be developed.
If anyone is waiting on this and wants to help, investigating what the exact behaviour change in v5 was would be useful.
… On 13 Mar 2021, at 23:56, Wei ***@***.***> wrote:
any updates on when we could get the fixes release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@glenjamin I am not 100% sure the issue, but I think it is related this middleware’s functions are not injecting to webpack 5 entry. E.g.: overlay and reload are both not working. With webpack 4 I can see the reload script is in the html, but not with webpack 5. |
@sokra the community struggles with this bug, can you please spend some time and advice on what was changed and how to migrate? |
@TrejGun What is bug? |
@alexander-akait https://github.com/webpack-contrib/webpack-hot-middleware/pull/394/files The author of this lib is not working with this stack any more and does not seem to be interested to fix his code but is responsive and will accept PR if any |
@TrejGun Can you provide link on bug or example? Should work... |
If/when I get time to poke at this a little deeper, my plan would be to:
If there are people who need this to work, they should be able to follow these steps themselves to work towards an understanding and then a solution. |
We have a fork of whm at gatsby that we're currently using in "Production" which works with fast-refresh, ... Changes we did on top of it are: I did not check for webpack 4 compatibility. |
@wardpeet should work with webpack v4 |
@wardpeet Your fork for the overlay is not working.
|
Is there any update on this? Maybe you could add a warning on the README warning that webpack 5 is not fully supported yet, since I had a hard time finding this issue |
@mcat95 you can check this issue |
After some tests, I can confirm that the fix proposed in fork https://github.com/lukeapage/webpack-hot-middleware#2cdfe0d0111dab6432b8683112fd2d17a5e80572 is working on Webpack 5. Good work, lukeapage! |
Any chance this gets merged? Fixes the overlay issue for our stack and it's always good to have at least partial support then none |
So there was supposedly a fix merged for the related issue webpack/webpack#12408, released with webpack 5.72.0, but when I look at that PR...I only see some test cases updated? I might not understand what those files in the PR actually impact... |
@chucknelson fix was in separate PR, in mentioned PR only test cases.. |
Thanks @vankop - I can't find the PR or commit for the actual fix. Do you happen to have a link to that PR? |
I spent a little time understanding what the remaining outstanding issue is - it does appear to be a change in webpack core, so I'm going to try and produce a minimal reproduction case and follow up there. If anyone knows of existing reports that aren't already linked from here - please do comment with links. The Problem Scenario
In webpack 5
In webpack 4
|
Any update on this? Or does anyone have a good replacement for this library? |
This PR contains a:
Motivation / Use-Case
Webpack 5 made some changes, which have broken error handling functions in hot middleware
Breaking Changes
None, this should remain compatible with v4.
I intend to configure CI to run the tests against v4 as a bit of insurance for this.
Additional Info
Supercedes #393
Will either incorporate the fix from #394 or some equivalent once the error is fully understood