WELD-2798 Secondary idea #3065
Closed
WELD-2798 Secondary idea #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
commented
Oct 1, 2024
| @@ -158,7 +144,18 @@ protected EnhancedAnnotatedTypeImpl(SlimAnnotatedType<T> annotatedType, | |||
| this.superclass = classTransformer.getEnhancedAnnotatedType(superclass, slim.getIdentifier().getBdaId()); | |||
| } | |||
| } else { | |||
| this.superclass = classTransformer.getEnhancedAnnotatedType(Object.class, AnnotatedTypeIdentifier.NULL_BDA_ID); | |||
| // TODO do we need the try-catch block? Since the class comes from an extension, do we always have access to it superclasses? | |||
There was a problem hiding this comment.
I am really not sure about this - we seemed to have been very deliberate in using Object as superclass here
manovotn
commented
Oct 1, 2024
Comment on lines
+345
to
+342
| for (Annotation ann : method.getAnnotations()) { | ||
| result.put(ann.annotationType(), method); |
There was a problem hiding this comment.
This change is not needed for the PR but fixes the inconsistency in the code - previously the collection of annotated methods only contained methods with certain annotations. This changes it to instead know about all annotated methods in given AT - which is what the API javadoc for EnhancedAnnotatedType#getEnhancedMethods(Class) states to begin with
|
Closing as these changes are now included in the original PR - #3055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serves to get a full CI run on this.
This fix aims to keep how Weld was working previously but changing the superclass of extension-based annotated types to their actually classes.