Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability for bottles to have a quota #97

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Jun 4, 2020

And use this to port HTML's 5 MiB suggestion.

See #95.


Preview | Diff

And use this to port HTML's 5 MiB suggestion.

See #95.
storage.bs Outdated Show resolved Hide resolved
storage.bs Outdated Show resolved Hide resolved
@annevk annevk requested a review from domenic June 5, 2020 11:09
@annevk annevk mentioned this pull request Jun 5, 2020
3 tasks
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like to defer to @inexorabletash as the actual domain expert

Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

<a for=/>set</a>.
<a for=/>set</a>. A <a>storage bottle</a> also has a <dfn for="storage bottle">quota</dfn>, which is
null or a number representing a conservative estimate of the total amount of bytes it can hold. Null
indicates the lack of a limit. <span class=note>It is still bound by the <a>storage quota</a> of its
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline notes? Sorcery!

@annevk annevk merged commit 6d251ad into master Jun 5, 2020
@annevk annevk deleted the annevk/bottle-quota branch June 5, 2020 17:57
Copy link
Collaborator

@asutherland asutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one might call this a throttled bottle? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants