Skip to content

Commit

Permalink
Merge pull request #4862 from wikimedia/image-rec/add-edit-summary-tag
Browse files Browse the repository at this point in the history
Restore image recs edit summary comment
  • Loading branch information
mazevedofs authored Jun 4, 2024
2 parents f07b1f8 + 49ab9db commit 9a52da8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions WKData/Sources/WKData/Models/Shared/WKEditSummaryTag.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ public enum WKEditSummaryTag: String {
case diffRollback = "#diff-rollback"
case talkReply = "#talk-reply"
case talkTopic = "#talk-topic"
case suggestedEditsAddImageTop = "#app-image-add-top"
}
1 change: 1 addition & 0 deletions Wikipedia/Code/ExploreViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1276,6 +1276,7 @@ extension ExploreViewController: EditPreviewViewControllerDelegate {
saveVC.wikitext = editPreviewViewController.wikitext
saveVC.cannedSummaryTypes = [.addedImage, .addedImageAndCaption]
saveVC.needsSuppressPosting = FeatureFlags.needsImageRecommendationsSuppressPosting
saveVC.editSummaryTag = .suggestedEditsAddImageTop

saveVC.delegate = self
saveVC.imageRecLoggingDelegate = self
Expand Down
2 changes: 1 addition & 1 deletion Wikipedia/Code/ImageRecommendationsFunnel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ final class ImageRecommendationsFunnel: NSObject {

func logSaveChangesPublishSuccess(timeSpent: Int?, revisionID: Int, captionAdded: Bool, altTextAdded: Bool, summaryAdded: Bool) {
var actionData = ["revision_id": "\(revisionID)",
"capion_add": "\(captionAdded)",
"caption_add": "\(captionAdded)",
"alt_text_add": "\(altTextAdded)",
"summary_add": "\(summaryAdded)"]
if let timeSpent {
Expand Down

0 comments on commit 9a52da8

Please sign in to comment.