Skip to content

Commit

Permalink
Merge pull request #5005 from wikimedia/fix-nav-items-disappearing
Browse files Browse the repository at this point in the history
Some fixes to fix disappearing nav bar items
  • Loading branch information
mazevedofs authored Oct 7, 2024
2 parents 0424d5f + 9c97293 commit cbde819
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions Wikipedia/Code/ArticleViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ class ArticleViewController: ViewController, HintPresenting {

if altTextExperimentViewModel == nil {
setupWButton()
setupSearchAndProfileButtons()
}

if isReturningFromFAQ {
Expand Down
5 changes: 5 additions & 0 deletions Wikipedia/Code/ExploreViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ class ExploreViewController: ColumnarCollectionViewController, ExploreCardViewCo
updateTabBarSnapshotImage()
}
}

navigationItem.titleView = titleView
updateProfileViewButton()
}

override func viewWillHaveFirstAppearance(_ animated: Bool) {
Expand Down Expand Up @@ -667,7 +670,9 @@ class ExploreViewController: ColumnarCollectionViewController, ExploreCardViewCo

self.theme = theme
// updateNotificationsCenterButton()
navigationItem.titleView = titleView
updateProfileViewButton()
tabBarSnapshotImage = nil

searchBar.apply(theme: theme)
searchBarContainerView.backgroundColor = theme.colors.paperBackground
Expand Down

0 comments on commit cbde819

Please sign in to comment.