module support #7

wingyplus · 2024-06-04T17:33:11Z

Tasks

Every library in the SDK must be netstandard 2.0!
Generate necessary attributes and interfaces for user code.
Generate registration method to convert user code into Dagger.Module for registering to the Dagger Engine.
- We need to traverse from root class (Potato.Potato for example) and generate child type from their.
Generate invoke function.
Make Dagger.SDK support JSON serialization
- We need it for returns the value when function get call.
- For example, Dagger.Container must serialize into Dagger.ContainerID.Value and deserialize it back.
- We can done this in Dagger.SDK.SourceGenerator by implementing json converter.
Remove my potato. 🥔

Idea on the next PR

Verify that namespace and class name must match with dagger module name to make sure we have only single entrypoint.
- I still doubt on how to do this at the moment. Maybe we can inject some configuration when Codegen get call.
~~Remove Dagger.SDK.Mod?~~
Implement project template. Maybe https://learn.microsoft.com/en-us/dotnet/core/tutorials/cli-templates-create-project-template can help us?

Closes #3

pjmagee · 2024-06-04T19:04:50Z

sdk/Dagger.SDK.SourceGenerator/Dagger.SDK.SourceGenerator/Code/CodeRenderer.cs

@@ -320,7 +320,7 @@ private static string RenderArgumentValue(InputValue arg, bool addVarSuffix = fa
            }
        }

-        throw new Exception($"The type {arg.Type.OfType.Kind} should not be enter here.");
+        throw new Exception($"The argument {arg} should not be enter here.");


should not be entered

main.go

pjmagee · 2024-06-04T19:07:53Z

This is looking exciting 👍

wingyplus · 2024-06-05T18:20:19Z

UPDATE: I just getting register module and simple invoke works in potato example. I also hit a bug that the SDK cannot retrieve array result, cause we cannot inject input arguments into our method correctly.

wingyplus · 2024-06-05T18:25:15Z

potato/dagger/Potato/Program.cs

+    {
+        var potato = JsonSerializer.Deserialize<Potato.Potato>(ParentJson.Value);
+        Debug.Assert(potato != null, nameof(potato) + " != null");
+        return await potato.Echo("C#");


I just hit a bug that program got crash when asking input args. So I do temporary hard code argument here to make it works.

wingyplus · 2024-06-28T07:57:09Z

sdk/Dagger.SDK.Mod/Dagger.SDK.Mod.csproj

@@ -0,0 +1,13 @@
+<Project Sdk="Microsoft.NET.Sdk">


If the source generator plan is going well, we don't need this package anymore. 🎉

wingyplus · 2024-06-28T07:59:04Z

sdk/Dagger.SDK.Mod.SourceGenerator.Tests/SourceGeneratorTests.cs

+namespace Dagger.SDK.Mod.SourceGenerator.Tests;
+
+[TestClass]
+public class SourceGeneratorTests : VerifyBase


I have discussion with Microsoft team in C# discord. They're recommended me to use https://www.nuget.org/packages/Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing#supportedframeworks-body-tab rather than Verify. I don't see much example from it but it would be nice if we strict with the Microsoft tools.

This is what I thought I had added here: https://github.com/wingyplus/dagger-dotnet-sdk/blob/main/sdk/Dagger.SDK.SourceGenerator/Dagger.SDK.SourceGenerator.Tests/Dagger.SDK.SourceGenerator.Tests.csproj#L17

wingyplus · 2024-06-28T08:34:34Z

sdk/Dagger.SDK.Mod.SourceGenerator/SourceGenerator.cs

+            postInitializationContext.AddSource("Dagger.SDK.Mod_Attributes.g.cs", ModuleAttributesSource());
+            postInitializationContext.AddSource("Dagger.SDK.Mod_Interfaces.g.cs", ModuleInterfacesSource());


I'm current stuck with the unit tests because in unit test, it has no reference to the Dagger.SDK.Mod, cause it to fail because it cannot find any class related to our SDK. That's why I put it to generator.

I think its difficult to convert to source generator once starting with reflection. It makes you need to change how to design/solution with TDD from the beginning

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Dagger.SDK.Mod hold the logic for construct and invoke function. Current implmentation using `System.Reflection` to scan class and method. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

And fix bug return list type broken. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Introduce a library to uses for generate sources via Source Generator. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

sdk/Dagger.SDK.Mod.SourceGenerator/SourceGenerator.cs

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

wingyplus marked this pull request as draft June 4, 2024 17:33

pjmagee reviewed Jun 4, 2024

View reviewed changes

main.go Outdated Show resolved Hide resolved

wingyplus force-pushed the module branch from d016afc to 4b91516 Compare June 5, 2024 10:31

wingyplus commented Jun 5, 2024

View reviewed changes

wingyplus force-pushed the module branch 2 times, most recently from 4546383 to b2b38f9 Compare June 20, 2024 18:24

wingyplus force-pushed the module branch from 90fe205 to ac47133 Compare June 22, 2024 18:26

wingyplus commented Jun 28, 2024

View reviewed changes

wingyplus added 17 commits June 29, 2024 15:07

feat: module support

5174b3d

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: support generating code

d492440

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: implement module runtime

86b9786

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

demo: add potato example module

8c8142e

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: register method from reflection

8e0add6

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix merge conflict broken

0dba32c

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix the code to not use id and move module code to new package

4124e5f

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix warnings

e0a01c8

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: introduce Dagger.SDK.Mod

8ad671a

Dagger.SDK.Mod hold the logic for construct and invoke function. Current implmentation using `System.Reflection` to scan class and method. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: call function work!

d481389

And fix bug return list type broken. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: introduce Dagger.SDK.Mod.SourceGenerator

f6d8193

Introduce a library to uses for generate sources via Source Generator. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix invalid import

2212e75

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix incorrect import again

1ac80ae

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: update Potato.sln

6dd9a2f

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

test: ensure namespace setting is correct

1a24e8e

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: filter only class that annotated with Dagger.SDK.Mod.Object

eb2aa59

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: try using ForAttributeWithMetadataName

23b8b78

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

wingyplus added 5 commits June 29, 2024 15:08

I get it!!!!

b50b08f

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: injecting mod attributes and interfaces from source generator

42e4fd5

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: convert my potato to use Dagger.SDK.Mod.SourceGenerator

1424d1b

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

chore: add question note

75a4ed0

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

chore: move generate sources to a new class

4ce669c

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

wingyplus force-pushed the module branch from c070f50 to 4ce669c Compare June 29, 2024 08:08

wingyplus added 2 commits June 30, 2024 16:30

feat: render register object type method

daebc78

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix dotnet format and refactor ToObjectTypeDef

6869719

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

wingyplus mentioned this pull request Jun 30, 2024

Dogfooding the runtime by rewriting dev module with our runtime #29

Open

wingyplus commented Jun 30, 2024

View reviewed changes

sdk/Dagger.SDK.Mod.SourceGenerator/SourceGenerator.cs Outdated Show resolved Hide resolved

wingyplus added 13 commits June 30, 2024 23:29

fix: make type registration works

a5d33b6

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: my potato dagger functions back to works

57614df

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

feat: move the logic parts in Main program to Entrypoint

e60576c

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

test: use Verify.SourceGenerators

7a9a606

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

test: add more tests

dad6a1f

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

test: reduce size of snapshot files

b651f71

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

test: reduce test size

b69822f

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

test: drop Verify

c56f8f0

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

chore: format code

9a7595a

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix test on unix

09a7f22

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: make it compatible with Dagger 0.13+

a0358b5

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

fix: fix cannot list a function

25872e5

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

refactor: move fetch function call to Dagger.SDK.Mod project

c627e9f

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

module support #7

module support #7

wingyplus commented Jun 4, 2024 •

edited

Loading

pjmagee Jun 4, 2024

pjmagee commented Jun 4, 2024

wingyplus commented Jun 5, 2024

wingyplus Jun 5, 2024

wingyplus Jun 28, 2024

wingyplus Jun 28, 2024

pjmagee Jun 29, 2024

wingyplus Jun 28, 2024

pjmagee Jun 29, 2024

		postInitializationContext.AddSource("Dagger.SDK.Mod_Attributes.g.cs", ModuleAttributesSource());
		postInitializationContext.AddSource("Dagger.SDK.Mod_Interfaces.g.cs", ModuleInterfacesSource());

module support #7

Are you sure you want to change the base?

module support #7

Conversation

wingyplus commented Jun 4, 2024 • edited Loading

Tasks

Idea on the next PR

pjmagee Jun 4, 2024

Choose a reason for hiding this comment

pjmagee commented Jun 4, 2024

wingyplus commented Jun 5, 2024

wingyplus Jun 5, 2024

Choose a reason for hiding this comment

wingyplus Jun 28, 2024

Choose a reason for hiding this comment

wingyplus Jun 28, 2024

Choose a reason for hiding this comment

pjmagee Jun 29, 2024

Choose a reason for hiding this comment

wingyplus Jun 28, 2024

Choose a reason for hiding this comment

pjmagee Jun 29, 2024

Choose a reason for hiding this comment

wingyplus commented Jun 4, 2024 •

edited

Loading