Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --engine-option to csvsql. #1256

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

sgpeter1
Copy link
Contributor

Adds --engine-option to csvsql. Similar to previous work in sql2csv to accommodate unique database configurations.

csvsql: adds --engine-option
@coveralls
Copy link

Coverage Status

coverage: 90.229% (-0.2%) from 90.454%
when pulling c1012ab on sgpeter1:master
into f63a247 on wireservice:master.

4 similar comments
@coveralls
Copy link

Coverage Status

coverage: 90.229% (-0.2%) from 90.454%
when pulling c1012ab on sgpeter1:master
into f63a247 on wireservice:master.

@coveralls
Copy link

Coverage Status

coverage: 90.229% (-0.2%) from 90.454%
when pulling c1012ab on sgpeter1:master
into f63a247 on wireservice:master.

@coveralls
Copy link

Coverage Status

coverage: 90.229% (-0.2%) from 90.454%
when pulling c1012ab on sgpeter1:master
into f63a247 on wireservice:master.

@coveralls
Copy link

Coverage Status

coverage: 90.229% (-0.2%) from 90.454%
when pulling c1012ab on sgpeter1:master
into f63a247 on wireservice:master.

@coveralls
Copy link

coveralls commented Jul 22, 2024

Coverage Status

coverage: 90.46% (+0.006%) from 90.454%
when pulling a23fcc0 on sgpeter1:master
into f63a247 on wireservice:master.

@sgpeter1 sgpeter1 marked this pull request as draft July 23, 2024 14:45
@sgpeter1
Copy link
Contributor Author

I'm embarrassed I can't figure out the lint issues here. What am I doing wrong?

@sgpeter1 sgpeter1 marked this pull request as ready for review July 23, 2024 15:30
@jpmckinney
Copy link
Member

jpmckinney commented Jul 23, 2024

Next time I think you can just do pip install isort and then isort . :)

@jpmckinney jpmckinney merged commit 6773cc0 into wireservice:master Jul 23, 2024
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants