CP-43468: push CPUID logic down from xapi into xenopsd #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t them
The feature sets are now treated as opaque data in xapi, and operations
on them are delegated to xenopsd. the two main operations are:
1. Combining host feature sets into a pool-level feature set. The
pool-level represents the lowest common denominator of CPU features.
It is assigned to VMs that are started on the pool, such that they
can migrate around to pool, to all hosts. The feature sets used for
this are the "default policies" from Xen in the
`features_{hvm;pv}_host` fields.
2. Compatibility checks for live migration. When asked to live-migrate a
VM to another host, a check is done to ensure that the host has all
the CPU features that the VM is currently exposed to. This check is
based on the "max policies" from Xen in the `features_{hvm;pv}`
fields.
The `Create_misc` module contains the logic for obtaining the hosts
feature sets from xenopsd, and combining them to construct the pool
level. This now uses the new `HOST.combine_cpu_features` call to
xenopsd.
This code used to send alerts for the case that CPU features
were removed from the pool-level, for example when adding a host to the
pool that doesn't have certain features. We can't do this kind of
comparison anymore, and therefore drop the alerting. We may put it back
in another form, later.
The compatibility checks are in `Cpuid_helpers`, which now uses the new
function `HOST.is_compatible`.
Signed-off-by: Rob Hoes <[email protected]>
(cherry picked from commit
xapi-project@dd3dc05)
Eventually, once everything CPUID-related is handled in libxc, all of these tests will be removed. Signed-off-by: Rob Hoes <[email protected]> (cherry picked from commit xapi-project@86f75db)
This was referenced Jul 5, 2023
psafont
approved these changes
Jul 5, 2023
lindig
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5076.
Depends on: