Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Unciv Windows ARM64 / Aarch64 builds #11909

Open
2 tasks done
touhidurrr opened this issue Jul 3, 2024 · 6 comments
Open
2 tasks done

Feature request: Unciv Windows ARM64 / Aarch64 builds #11909

touhidurrr opened this issue Jul 3, 2024 · 6 comments

Comments

@touhidurrr
Copy link
Contributor

touhidurrr commented Jul 3, 2024

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

It would be nice if we had this. Kind of an early support?

Related Issue Links

No response

Desired Solution

.exe aside, we need correct jre. Some candidates are:
Temurin 21 from here: https://adoptium.net/temurin/nightly/?version=21
Microsoft OpenJDK 11: https://github.com/microsoft/openjdk-aarch64/releases/tag/jdk-11.0.12-ga

I would suggest Temurin 21 (cause 11 does not have arm builds). Microsoft one is quite old. I personally always play Unciv with my locally installed Temurin 21 (now GraalVM 22) without any issues. So, there should not be any problems with using Temurin 21.

If packr does not support it yet, we need to write a .bat file to run it maybe? .exe that we currently ship is the same right? Users would need to click on it anyways.

Alternative Approaches

Not Sure.

Additional Context

  1. Recent hype regarding Snapdragon ARM chips on Windows.
  2. Not sure if packr supports ARM yet.
@touhidurrr
Copy link
Contributor Author

touhidurrr commented Jul 3, 2024

Wow, did not see this:
https://www.azul.com/downloads/?os=windows&architecture=arm-64-bit#zulu
This looks better as it specifically says ARMv8 (not the general Aaarch64) so should be more performant?
Again, 21 is recommended.

@yairm210
Copy link
Owner

yairm210 commented Jul 3, 2024

We'll need a way to test this though
I don't have Windows at all, we'll need to ask if anyone has ARM Windows
Interesting point regarding Linux as well, looks like ARM is becoming mainstream...

@touhidurrr
Copy link
Contributor Author

touhidurrr commented Jul 3, 2024

Oh, also, do you have any intention of trying to ship standalone binaries of Unciv with GraalVM? For all releases. This will simplify the download / play process.

@yairm210
Copy link
Owner

yairm210 commented Jul 3, 2024

I don't plan to, I already spend way too much time dealing with distribution issues as it is
Just this week there's the AUR issue, Flatpak stopped auto-releases, and I investigated Snapcraft (no-go, their latest cores don't support gradle, bizarrely)

If you get it working I'm fine with adding it in to the pipeline

Also, why would it be any better? What's the difference between out current standalones and that?

@touhidurrr
Copy link
Contributor Author

Ok, I will explore this Idea and the GraalVM one also.

@touhidurrr touhidurrr mentioned this issue Jul 4, 2024
3 tasks
Copy link

github-actions bot commented Oct 2, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants