Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows ARM64 Builds #11915

Closed
wants to merge 2 commits into from
Closed

Windows ARM64 Builds #11915

wants to merge 2 commits into from

Conversation

touhidurrr
Copy link
Contributor

@touhidurrr touhidurrr commented Jul 4, 2024

resolves #11909

  • Test that the script works in your system with appropriate download link
  • The produced zip can be extracted using Windows "Extract All..." option
  • Clicking Unciv.bat runs Unciv properly

@touhidurrr
Copy link
Contributor Author

touhidurrr commented Jul 4, 2024

Possible way to test this:

  • Test that the script works in your system with appropriate download link

Since windows works the same way. The only difference for ARM builds would be the JRE that we shipped. Thus if it works with appropriate JRE link in our system, we can be sure that it would work with appropriate JRE in Windows ARM64.

@touhidurrr
Copy link
Contributor Author

Running the script with WSL produced this output:
image

After opening Unciv.zip with 7z, can confirm that the contents are correct:
image

The produced zip could be extracted from Windows built in "Extract All..." option. And double clicking the .bat file DOES run Unciv properly.

@touhidurrr touhidurrr closed this Jul 4, 2024
@touhidurrr touhidurrr deleted the patch-1 branch July 4, 2024 21:37
@touhidurrr touhidurrr restored the patch-1 branch July 4, 2024 21:37
@touhidurrr touhidurrr reopened this Jul 4, 2024
@touhidurrr
Copy link
Contributor Author

touhidurrr commented Jul 4, 2024

Now, the remaining test would be to see if this correctly adds Unciv-WindowsARM64.zip in releases which I am not sure how can I check that. So, this PR can be considered ok to go.

@yairm210
Copy link
Owner

yairm210 commented Jul 5, 2024

Is there a reason not to use packr? This looks exactly like what packr does, we could just change the JDK in between x86 and ARM builds

@yairm210
Copy link
Owner

yairm210 commented Jul 5, 2024

If we see that doesn't work we can try this but it seems unnecessary if the current path will suffice
Also the final download will be smaller, since packr throws away unnecessary parts of the JRE

@touhidurrr
Copy link
Contributor Author

Is there a reason not to use packr? This looks exactly like what packr does, we could just change the JDK in between x86 and ARM builds

Hmm... They officially does not support ARM yet... But ARM devices can emulate x64 code so this might work... But again not sure how to test this, also not sure how to configure packr...

@yairm210
Copy link
Owner

yairm210 commented Jul 7, 2024

theoretically just replace the existing "windows 64 bit" JDK in the CI flow with your JDK and it'll use that one
The real question is: How is the .exe file constructed? If it's x86 specific then this will not work, if it's generic (like your batch file) then it will
Do you actually have a Windows ARM where you can test this?

@touhidurrr touhidurrr closed this Jul 7, 2024
@touhidurrr touhidurrr deleted the patch-1 branch July 7, 2024 20:06
@touhidurrr touhidurrr restored the patch-1 branch July 7, 2024 21:44
@touhidurrr touhidurrr reopened this Jul 7, 2024
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Aug 22, 2024
Copy link

github-actions bot commented Sep 1, 2024

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Unciv Windows ARM64 / Aarch64 builds
2 participants